Skip to content

Commit

Permalink
Merge pull request #1316 from JohnVillalovos/jlvillal/test_wait
Browse files Browse the repository at this point in the history
test: extend wait timeout for test_delete_user()
  • Loading branch information
nejch committed Feb 21, 2021
2 parents 2b29776 + 19fde8e commit 5cc60d5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
3 changes: 2 additions & 1 deletion tools/functional/api/test_users.py
Expand Up @@ -56,7 +56,8 @@ def test_delete_user(gl, wait_for_sidekiq):
)

new_user.delete()
wait_for_sidekiq()
result = wait_for_sidekiq(timeout=60)
assert result == True, "sidekiq process should have terminated but did not"

assert new_user.id not in [user.id for user in gl.users.list()]

Expand Down
10 changes: 8 additions & 2 deletions tools/functional/conftest.py
Expand Up @@ -89,9 +89,15 @@ def wait_for_sidekiq(gl):

def _wait(timeout=30, step=0.5):
for _ in range(timeout):
if not gl.sidekiq.process_metrics()["processes"][0]["busy"]:
return
time.sleep(step)
busy = False
processes = gl.sidekiq.process_metrics()["processes"]
for process in processes:
if process["busy"]:
busy = True
if not busy:
return True
return False

return _wait

Expand Down

0 comments on commit 5cc60d5

Please sign in to comment.