Skip to content

Commit

Permalink
Fix the 'invalid syntax' on Python 3.2, because of u'password'
Browse files Browse the repository at this point in the history
More informations regarding this issue:

Operating system: Debian Wheezy, with Python 3.2 and the last
version of python-gitlab.

The gitlab module raised this exception, because of the 'u' (Unicode):

Traceback (most recent call last):
  File "push_settings.py", line 14, in <module>
    from helper import ROOT_EMAIL, ADMINS, git, old_git
  File "/opt/scripts/gitlab/helpers/helper.py", line 25, in <module>
    from gitlab import Gitlab
  File "/opt/scripts/gitlab/helpers/gitlab/__init__.py", line 32, in <module>
    from gitlab.objects import *  # noqa
  File "/opt/scripts/gitlab/helpers/gitlab/objects.py", line 546
    selfdict.pop(u'password', None)
			   ^
SyntaxError: invalid syntax
It is a recent change:
01802c0 (Richard Hansen 2016-02-11 22:43:25 -0500 546) selfdict.pop(u'password', None)
01802c0 (Richard Hansen 2016-02-11 22:43:25 -0500 547) otherdict.pop(u'password', None)

To solve the issue, 'u' was removed.
  • Loading branch information
Asher256 committed Mar 2, 2016
1 parent 453224a commit 7ed84a7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gitlab/objects.py
Expand Up @@ -543,8 +543,8 @@ def __eq__(self, other):
if type(other) is type(self):
selfdict = self.as_dict()
otherdict = other.as_dict()
selfdict.pop(u'password', None)
otherdict.pop(u'password', None)
selfdict.pop('password', None)
otherdict.pop('password', None)
return selfdict == otherdict
return False

Expand Down

0 comments on commit 7ed84a7

Please sign in to comment.