Skip to content

Commit

Permalink
chore: fix E712 errors reported by flake8
Browse files Browse the repository at this point in the history
E712: Comparison to true should be 'if cond is true:' or 'if cond:'

https://www.flake8rules.com/rules/E712.html
  • Loading branch information
JohnVillalovos committed Apr 18, 2021
1 parent 380f227 commit 83670a4
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
6 changes: 3 additions & 3 deletions gitlab/tests/objects/test_project_merge_request_approvals.py
Expand Up @@ -241,7 +241,7 @@ def test_project_approval_manager_update_uses_post(project, resp_snippet):
assert isinstance(
approvals, gitlab.v4.objects.merge_request_approvals.ProjectApprovalManager
)
assert approvals._update_uses_post == True
assert approvals._update_uses_post is True


def test_list_merge_request_approval_rules(project, resp_snippet):
Expand All @@ -257,7 +257,7 @@ def test_update_merge_request_approvals_set_approvers(project, resp_snippet):
approvals,
gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager,
)
assert approvals._update_uses_post == True
assert approvals._update_uses_post is True
response = approvals.set_approvers(
updated_approval_rule_approvals_required,
approver_ids=updated_approval_rule_user_ids,
Expand All @@ -277,7 +277,7 @@ def test_create_merge_request_approvals_set_approvers(project, resp_snippet):
approvals,
gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager,
)
assert approvals._update_uses_post == True
assert approvals._update_uses_post is True
response = approvals.set_approvers(
new_approval_rule_approvals_required,
approver_ids=new_approval_rule_user_ids,
Expand Down
14 changes: 7 additions & 7 deletions gitlab/tests/objects/test_runners.py
Expand Up @@ -200,31 +200,31 @@ def resp_runner_verify():

def test_owned_runners_list(gl: gitlab.Gitlab, resp_get_runners_list):
runners = gl.runners.list()
assert runners[0].active == True
assert runners[0].active is True
assert runners[0].id == 6
assert runners[0].name == "test-name"
assert len(runners) == 1


def test_project_runners_list(gl: gitlab.Gitlab, resp_get_runners_list):
runners = gl.projects.get(1, lazy=True).runners.list()
assert runners[0].active == True
assert runners[0].active is True
assert runners[0].id == 6
assert runners[0].name == "test-name"
assert len(runners) == 1


def test_group_runners_list(gl: gitlab.Gitlab, resp_get_runners_list):
runners = gl.groups.get(1, lazy=True).runners.list()
assert runners[0].active == True
assert runners[0].active is True
assert runners[0].id == 6
assert runners[0].name == "test-name"
assert len(runners) == 1


def test_all_runners_list(gl: gitlab.Gitlab, resp_get_runners_list):
runners = gl.runners.all()
assert runners[0].active == True
assert runners[0].active is True
assert runners[0].id == 6
assert runners[0].name == "test-name"
assert len(runners) == 1
Expand All @@ -238,7 +238,7 @@ def test_create_runner(gl: gitlab.Gitlab, resp_runner_register):

def test_get_update_runner(gl: gitlab.Gitlab, resp_runner_detail):
runner = gl.runners.get(6)
assert runner.active == True
assert runner.active is True
runner.tag_list.append("new")
runner.save()

Expand All @@ -259,14 +259,14 @@ def test_disable_group_runner(gl: gitlab.Gitlab, resp_runner_disable):

def test_enable_project_runner(gl: gitlab.Gitlab, resp_runner_enable):
runner = gl.projects.get(1, lazy=True).runners.create({"runner_id": 6})
assert runner.active == True
assert runner.active is True
assert runner.id == 6
assert runner.name == "test-name"


def test_enable_group_runner(gl: gitlab.Gitlab, resp_runner_enable):
runner = gl.groups.get(1, lazy=True).runners.create({"runner_id": 6})
assert runner.active == True
assert runner.active is True
assert runner.id == 6
assert runner.name == "test-name"

Expand Down
6 changes: 3 additions & 3 deletions gitlab/tests/test_config.py
Expand Up @@ -156,7 +156,7 @@ def test_valid_data(m_open, path_exists):
assert "ABCDEF" == cp.private_token
assert None == cp.oauth_token
assert 2 == cp.timeout
assert True == cp.ssl_verify
assert cp.ssl_verify is True
assert cp.per_page is None

fd = io.StringIO(valid_config)
Expand All @@ -168,7 +168,7 @@ def test_valid_data(m_open, path_exists):
assert "GHIJKL" == cp.private_token
assert None == cp.oauth_token
assert 10 == cp.timeout
assert False == cp.ssl_verify
assert cp.ssl_verify is False

fd = io.StringIO(valid_config)
fd.close = mock.Mock(return_value=None)
Expand All @@ -191,7 +191,7 @@ def test_valid_data(m_open, path_exists):
assert None == cp.private_token
assert "STUV" == cp.oauth_token
assert 2 == cp.timeout
assert True == cp.ssl_verify
assert cp.ssl_verify is True


@mock.patch("os.path.exists")
Expand Down
2 changes: 1 addition & 1 deletion gitlab/tests/test_gitlab_http_methods.py
Expand Up @@ -219,7 +219,7 @@ def resp_cont(url, request):
with HTTMock(resp_cont):
result = gl.http_delete("/projects")
assert isinstance(result, requests.Response)
assert result.json() == True
assert result.json() is True


def test_delete_request_404(gl):
Expand Down

0 comments on commit 83670a4

Please sign in to comment.