Skip to content

Commit

Permalink
chore: correct test_groups.py test
Browse files Browse the repository at this point in the history
The test was checking twice if the same group3 was not in the returned
list.  Should have been checking for group3 and group4.

Also added a test that only skipped one group and checked that the
group was not in the returned list and a non-skipped group was in the
list.
  • Loading branch information
JohnVillalovos committed Nov 20, 2021
1 parent 2cd15ac commit 9c878a4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/functional/api/test_groups.py
Expand Up @@ -36,7 +36,11 @@ def test_groups(gl):

filtered_groups = gl.groups.list(skip_groups=[group3.id, group4.id])
assert group3 not in filtered_groups
assert group4 not in filtered_groups

filtered_groups = gl.groups.list(skip_groups=[group3.id])
assert group3 not in filtered_groups
assert group4 in filtered_groups

group1.members.create(
{"access_level": gitlab.const.OWNER_ACCESS, "user_id": user.id}
Expand Down

0 comments on commit 9c878a4

Please sign in to comment.