feat: usernames support for MR approvals

This can be used instead of 'user_ids' See: https://docs.gitlab.com/ee/api/merge_request_approvals.html#create-project-level-rule
python-gitlab · Apr 19, 2023 · a2b8c8c · a2b8c8c
1 parent f310764
commit a2b8c8c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
@@ -63,7 +63,7 @@ class ProjectApprovalRuleManager(
     _from_parent_attrs = {"project_id": "id"}
     _create_attrs = RequiredOptional(
         required=("name", "approvals_required"),
-        optional=("user_ids", "group_ids", "protected_branch_ids"),
+        optional=("user_ids", "group_ids", "protected_branch_ids", "usernames"),
     )