Merge pull request #1488 from JohnVillalovos/jlvillal/add_missing_option

chore: add missing optional create parameter for approval_rules
python-gitlab · Jun 1, 2021 · ac92205 · ac92205
2 parents a11623b + 06a6001
commit ac92205
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
@@ -72,7 +72,8 @@ class ProjectApprovalRuleManager(
     _obj_cls = ProjectApprovalRule
     _from_parent_attrs = {"project_id": "id"}
     _create_attrs = RequiredOptional(
-        required=("name", "approvals_required"), optional=("user_ids", "group_ids")
+        required=("name", "approvals_required"),
+        optional=("user_ids", "group_ids", "protected_branch_ids"),
     )