Skip to content

Commit

Permalink
fix(base): really refresh object
Browse files Browse the repository at this point in the history
This fixes and error, where deleted attributes would not show up

Fixes #1155
  • Loading branch information
max-wittig committed Oct 12, 2020
1 parent 3a38c6d commit e1e0d8c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion gitlab/base.py
Expand Up @@ -131,7 +131,7 @@ def _create_managers(self):

def _update_attrs(self, new_attrs):
self.__dict__["_updated_attrs"] = {}
self.__dict__["_attrs"].update(new_attrs)
self.__dict__["_attrs"] = new_attrs

def get_id(self):
"""Returns the id of the resource."""
Expand Down
7 changes: 7 additions & 0 deletions gitlab/tests/test_base.py
Expand Up @@ -128,6 +128,13 @@ def test_update_attrs(self, fake_manager):
assert {"foo": "foo", "bar": "bar"} == obj._attrs
assert {} == obj._updated_attrs

def test_update_attrs_deleted(self, fake_manager):
obj = FakeObject(fake_manager, {"foo": "foo", "bar": "bar"})
obj.bar = "baz"
obj._update_attrs({"foo": "foo"})
assert {"foo": "foo"} == obj._attrs
assert {} == obj._updated_attrs

def test_create_managers(self, fake_gitlab, fake_manager):
class ObjectWithManager(FakeObject):
_managers = (("fakes", "FakeManager"),)
Expand Down

0 comments on commit e1e0d8c

Please sign in to comment.