Gitlab.update(): use the proper attributes if defined

python-gitlab · Mar 19, 2016 · f8528cc · f8528cc
1 parent e48e4ac
commit f8528cc
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/gitlab/__init__.py b/gitlab/__init__.py
@@ -567,8 +567,11 @@ def update(self, obj, **kwargs):
         params = obj.__dict__.copy()
         params.update(kwargs)
         missing = []
-        for k in itertools.chain(obj.requiredUrlAttrs,
-                                 obj.requiredCreateAttrs):
+        if obj.requiredUpdateAttrs or obj.optionalUpdateAttrs:
+            required_attrs = obj.requiredUpdateAttrs
+        else:
+            required_attrs = obj.requiredCreateAttrs
+        for k in itertools.chain(obj.requiredUrlAttrs, required_attrs):
             if k not in params:
                 missing.append(k)
         if missing: