Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/projects/:id/merge_requests/:iid/approval_rules is not supported #1199

Closed
robinson96 opened this issue Sep 29, 2020 · 3 comments
Closed

/projects/:id/merge_requests/:iid/approval_rules is not supported #1199

robinson96 opened this issue Sep 29, 2020 · 3 comments
Labels
EE Issues related to the enterprise version of GitLab

Comments

@robinson96
Copy link
Contributor

Description of the problem, including code/CLI snippet

I would like to be able to call the /projects/:id/merge_requests/:iid/approval_rules endpoint as well as associated gets and updates.

https://docs.gitlab.com/ee/api/merge_request_approvals.html#get-merge-request-level-rules
https://docs.gitlab.com/ee/api/merge_request_approvals.html#create-merge-request-level-rule
https://docs.gitlab.com/ee/api/merge_request_approvals.html#update-merge-request-level-rule

Expected Behavior

Being able to call the endpoint, being able to get a list of approval_rules, create new rules, and update them.

Actual Behavior

Endpoint not exposed in python-gitlab API

Specifications

  • python-gitlab version: latest
  • API version you are using (v3/v4): v4
  • Gitlab server version (or gitlab.com): latest

FYI

I actually have a branch where I've implemented this. PR should be up soon

robinson96 added a commit to robinson96/python-gitlab that referenced this issue Sep 30, 2020
@max-wittig max-wittig added the EE Issues related to the enterprise version of GitLab label Oct 12, 2020
@axelfauvel
Copy link

Hi there, any idea on how this feature will be released ? I'm interested :)
Thanks

@robinson96
Copy link
Contributor Author

Hi there, any idea on how this feature will be released ? I'm interested :)
Thanks

It has been merged into master.

@nejch
Copy link
Member

nejch commented May 2, 2021

Shipped in v2.6.0 via #1200.

@nejch nejch closed this as completed May 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EE Issues related to the enterprise version of GitLab
Projects
None yet
Development

No branches or pull requests

4 participants