Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow update of protected branches #2390

Closed
hoerup opened this issue Nov 23, 2022 · 3 comments · Fixed by #2771
Closed

Allow update of protected branches #2390

hoerup opened this issue Nov 23, 2022 · 3 comments · Fixed by #2771
Labels
EE Issues related to the enterprise version of GitLab feature help wanted

Comments

@hoerup
Copy link

hoerup commented Nov 23, 2022

In gitlab 15.6 gitlab finally added api support to update protected branch settings, so ProjectProtectedBranch should be updated accordingly

https://gitlab.com/gitlab-org/gitlab/-/issues/20229/

@nejch nejch added feature EE Issues related to the enterprise version of GitLab labels Nov 23, 2022
@nejch
Copy link
Member

nejch commented Nov 23, 2022

This is a premium feature and we'll need to add a http_patch method for this as well.

Edit: And once the Free version PUT endpoint is implemented, we kind of need to be able to distinguish that in the .save() and .update() methods.

@JohnVillalovos
Copy link
Member

@Hokwang
Copy link

Hokwang commented Jul 10, 2023

I think free version will have this endpoint. We know gitlab developers, right?
How about provide .save() or .update() anyway?

Sjord added a commit to Sjord/python-gitlab that referenced this issue Jan 21, 2024
JohnVillalovos pushed a commit to Sjord/python-gitlab that referenced this issue Jan 28, 2024
Sjord added a commit to Sjord/python-gitlab that referenced this issue Jan 28, 2024
Sjord added a commit to Sjord/python-gitlab that referenced this issue Jan 28, 2024
nejch pushed a commit to Sjord/python-gitlab that referenced this issue Feb 10, 2024
nejch pushed a commit that referenced this issue Feb 10, 2024
* feat(api): allow updating protected branches

Closes #2390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EE Issues related to the enterprise version of GitLab feature help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants