Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib3>=2 breaks unit tests #2626

Closed
JohnVillalovos opened this issue Jul 24, 2023 · 2 comments · Fixed by #2627
Closed

urllib3>=2 breaks unit tests #2626

JohnVillalovos opened this issue Jul 24, 2023 · 2 comments · Fixed by #2627

Comments

@JohnVillalovos
Copy link
Collaborator

requests 2.30.0 switched to using urllib3 v2 by default. This is breaking the unit tests.

https://github.com/psf/requests/releases/tag/v2.30.0

⚠️ Added support for urllib3 2.0. ⚠️

This may contain minor breaking changes so we advise careful testing and
reviewing https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html
prior to upgrading.

Users who wish to stay on urllib3 1.x can pin to urllib3<2.
JohnVillalovos added a commit that referenced this issue Jul 24, 2023
@JohnVillalovos
chore(deps): update dependency requests to v2.31.0 [security]
456e4ca 
 At the moment need to pin `urllib3<2` as unit tests break.

 #2626
JohnVillalovos added a commit that referenced this issue Jul 24, 2023
@JohnVillalovos
chore(deps): update dependency requests to v2.31.0 [security]
3bc111e 
 At the moment need to pin `urllib3<2` as unit tests break.

 #2626
@JohnVillalovos JohnVillalovos mentioned this issue Jul 24, 2023
Merged
@JohnVillalovos
Copy link
Collaborator Author

I think we will require a new release of responses to come out to fix this issue.

getsentry/responses#652

JohnVillalovos added a commit that referenced this issue Jul 25, 2023
@JohnVillalovos
chore(deps): update dependency requests to v2.31.0 [security]
cc7718c 
Also update dependency `responses==0.23.2` as it provides support for
`urllib3>=2`

Closes: #2626
@JohnVillalovos
Copy link
Collaborator Author

I think we will require a new release of responses to come out to fix this issue.

getsentry/responses#652

New version has been released. I have updated the PR

JohnVillalovos added a commit that referenced this issue Aug 2, 2023
@JohnVillalovos
chore(deps): update dependency requests to v2.31.0 [security]
1dd85ec 
Also update dependency `responses==0.23.2` as it provides support for
`urllib3>=2`

Closes: #2626
JohnVillalovos added a commit that referenced this issue Aug 2, 2023
@JohnVillalovos
chore(deps): update dependency requests to v2.31.0 [security]
053b030 
Also update dependency `responses==0.23.3` as it provides support for
`urllib3>=2`

Closes: #2626
nejch pushed a commit that referenced this issue Aug 19, 2023
@JohnVillalovos @nejch
chore(deps): update dependency requests to v2.31.0 [security]
988a6e7 
Also update dependency `responses==0.23.3` as it provides support for
`urllib3>=2`

Closes: #2626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): update dependency requests to v2.31.0 [security] python-gitlab/python-gitlab
1 participant
@JohnVillalovos