Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for commit revert API (#991) #1020

Merged
merged 6 commits into from Feb 20, 2020
Merged

feat: add support for commit revert API (#991) #1020

merged 6 commits into from Feb 20, 2020

Conversation

nejch
Copy link
Member

@nejch nejch commented Feb 18, 2020 •
edited

Closes #991.

@nejch nejch closed this Feb 18, 2020
@nejch nejch reopened this Feb 18, 2020
@nejch
Copy link
Member Author

nejch commented Feb 18, 2020

Hmm, Travis was failing on something seemingly unrelated in functional tests (https://travis-ci.org/python-gitlab/python-gitlab/jobs/652064210), so I re-opened the PR to trigger it again and now it's happy. ¯\_(ツ)_/¯

@nejch nejch marked this pull request as ready for review February 19, 2020 00:04
@nejch
Copy link
Member Author

nejch commented Feb 19, 2020

I was wondering if maybe revert() should return a commit object instead of a dict. It seems like most other update methods also just return the server response but since this creates a new resource, people might want to manipulate that new commit directly - I just didn't see any other examples (cherry_pick doesn't return anything atm).

max-wittig
max-wittig approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment. Feel free to ignore it. It's not a big deal.

Thanks for the MR!

gitlab/tests/test_gitlab.py Outdated Show resolved Hide resolved
@nejch nejch removed their assignment Feb 19, 2020
@max-wittig max-wittig merged commit e8f0921 into python-gitlab:master Feb 20, 2020
@max-wittig
Copy link
Member

Thanks for the MR!

@nejch nejch deleted the feat/revert-commit-api branch February 22, 2020 17:13
@nejch nejch mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig max-wittig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to revert a commit of a project
2 participants
@nejch @max-wittig