Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make RESTObject._short_print_attrs always present #1410

Merged
merged 1 commit into from Apr 25, 2021
Merged

chore: make RESTObject._short_print_attrs always present #1410

merged 1 commit into from Apr 25, 2021

Conversation

JohnVillalovos
Copy link
Collaborator

Always create RESTObject._short_print_attrs with a default value of
None.

This way we don't need to use hasattr() and we will know the type of
the attribute.

Always create RESTObject._short_print_attrs with a default value of
None.

This way we don't need to use hasattr() and we will know the type of
the attribute.
@codecov-commenter
Copy link

Codecov Report

Merging #1410 (6d55120) into master (4f79dff) will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1410   +/-   ##
=======================================
  Coverage   80.20%   80.20%           
=======================================
  Files          73       73           
  Lines        4067     4067           
=======================================
  Hits         3262     3262           
  Misses        805      805           
Flag Coverage Δ
unit 80.20% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/cli.py 41.63% <0.00%> (ø)
gitlab/base.py 88.60% <100.00%> (+0.07%) ⬆️
gitlab/client.py 78.96% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc42d2...6d55120. Read the comment docs.

@max-wittig
Copy link
Member

Makes sense

@max-wittig max-wittig merged commit 09522b3 into python-gitlab:master Apr 25, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/short_print_attr branch January 4, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants