Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add project milestone promotion #1655

Merged
merged 1 commit into from Oct 31, 2021

Conversation

StingRayZA
Copy link
Contributor

Adds promotion to Project Milestones

Fixes #1654

Adds promotion to Project Milestones

Signed-off-by: Raimund Hook <raimund.hook@exfo.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #1655 (f068520) into main (0b53c0a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
+ Coverage   91.95%   91.97%   +0.02%     
==========================================
  Files          74       74              
  Lines        4323     4324       +1     
==========================================
+ Hits         3975     3977       +2     
+ Misses        348      347       -1     
Flag Coverage Δ
cli_func_v4 81.86% <100.00%> (+<0.01%) ⬆️
py_func_v4 81.10% <100.00%> (+0.02%) ⬆️
unit 83.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/milestones.py 100.00% <100.00%> (ø)
gitlab/mixins.py 91.54% <0.00%> (+0.24%) ⬆️

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StingRayZA looks good, and the PromoteMixin does make sense now.

A group project fixture (instead of personal ones) might be useful in the future if we do more of this.

@nejch nejch merged commit 5ce3b17 into python-gitlab:main Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support Milestone Promotion
3 participants