-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make reset_gitlab() better #1785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
from
December 29, 2021 07:43
ea4c50d
to
4acdecc
Compare
JohnVillalovos
changed the title
wip: make reset_gitlab() better
chore: make reset_gitlab() better
Dec 29, 2021
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
from
December 29, 2021 07:53
4acdecc
to
63c6793
Compare
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
from
December 29, 2021 08:07
63c6793
to
60e2907
Compare
@nejch Please look at the functional testing logs and let me know what you think. |
An example of what this is fixing from https://github.com/python-gitlab/python-gitlab/runs/4656774636?check_suite_focus=true#step:5:27
|
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
2 times, most recently
from
December 29, 2021 17:14
3c5f510
to
cda90f0
Compare
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
3 times, most recently
from
December 31, 2021 21:14
26f4944
to
67dd7b4
Compare
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
from
June 2, 2022 04:39
67dd7b4
to
517a330
Compare
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
from
June 12, 2022 16:29
517a330
to
48710b7
Compare
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
from
June 20, 2022 17:40
48710b7
to
0480644
Compare
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
from
June 30, 2022 00:57
0480644
to
6bc9dfd
Compare
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
2 times, most recently
from
July 22, 2022 15:21
e9e8a7c
to
9b4c01b
Compare
Saw issues in the CI where reset_gitlab() would fail. It would fail to delete the group that is created when GitLab starts up. Extending the timeout didn't fix the issue. Changed the code to use the new `helpers.safe_delete()` function. Which will delete the resource and then make sure it is deleted before returning. Also added some logging functionality that can be seen if logging is turned on in pytest.
JohnVillalovos
force-pushed
the
jlvillal/reset_gitlab
branch
from
July 22, 2022 15:23
9b4c01b
to
d87d6b1
Compare
@nejch By using |
Amazing, love to see code get deleted 😅 |
nejch
reviewed
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw issues in the CI where reset_gitlab() would fail. It would fail to
delete the group that is created when GitLab starts up. Extending the
timeout didn't fix the issue.
Changed the code to use the new
helpers.safe_delete()
function.Which will delete the resource and then make sure it is deleted before
returning.
Also added some logging functionality that can be seen if logging is
turned on in pytest.