New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): url-encode path components of the URL #1790
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1790 +/- ##
==========================================
+ Coverage 92.02% 92.03% +0.01%
==========================================
Files 76 76
Lines 4790 4798 +8
==========================================
+ Hits 4408 4416 +8
Misses 382 382
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d7ee0cb
to
ae97e4d
Compare
f2cc3cf
to
3a75d87
Compare
3a75d87
to
3243735
Compare
3243735
to
4b779bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks John. Just a few suggestions and could you maybe rename the commit message to say fix(cli): ...
so that it's parsed as a scope?
Previously c8256a5 was done to fix this but it missed two other failures.
4b779bd
to
79b1cc0
Compare
In the CLI we need to make sure the components put into the path portion of the URL are url-encoded. Otherwise they will be interpreted as part of the path. For example can specify the project ID as a path, but in the URL it must be url-encoded or it doesn't work. Also stop adding the components of the path as query parameters in the URL. Closes: #783 Closes: #1498
79b1cc0
to
ac1c619
Compare
Done! |
In the CLI we need to make sure the components put into the path
portion of the URL are url-encoded. Otherwise they will be interpreted
as part of the path. For example can specify the project ID as a path,
but in the URL it must be url-encoded or it doesn't work.
Also stop adding the components of the path as query parameters in the
URL.
Closes: #783
Closes: #1498