Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): services: add missing lazy parameter #1829

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

JohnVillalovos
Copy link
Member

Commit 8da0b75 added the lazy
parameter to the services get() method but missed then using the
lazy parameter when it called super(...).get(...)

Closes: #1828

Commit 8da0b75 added the `lazy`
parameter to the services `get()` method but missed then using the
`lazy` parameter when it called `super(...).get(...)`

Closes: #1828
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick action @JohnVillalovos! Seems like we have two scopes in the commit message somehow 😁 but all good I think

@nejch nejch merged commit 824151c into main Jan 13, 2022
@nejch nejch deleted the jlvillal/lazy_service branch January 13, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy creation of service object still fails with 404 error
2 participants