docs:Small docs fixup for application scopes #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wacuuu
changed the title
|
Thanks for the catch @wacuuu! Surprised to see they're using space-delimited strings here, in most other places they use arrays for Could you please rebase again as there was a recent broken version of black that breaks our CI? psf/black#2964. |
|
Oh, so that is why linter broke. I couldn't understand what is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I found a small hickup in the docs that took me a few minutes to understand. Looking at API docs and the code I have found out that the way we try to push the application scopes doesn't match the API. I'd like to leave an appropriate example in docs so that people don't get stuck on this