Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require f-strings #2043

Merged
merged 1 commit into from Jun 1, 2022
Merged

chore: require f-strings #2043

merged 1 commit into from Jun 1, 2022

Conversation

JohnVillalovos
Copy link
Collaborator

We previously converted all string formatting to use f-strings. Enable
pylint check to enforce this.

@codecov-commenter
Copy link

Codecov Report

Merging #2043 (7fa19e0) into main (7327f78) will increase coverage by 5.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2043      +/-   ##
==========================================
+ Coverage   88.89%   94.22%   +5.32%     
==========================================
  Files          78       78              
  Lines        4972     4972              
==========================================
+ Hits         4420     4685     +265     
+ Misses        552      287     -265     
Flag Coverage Δ
cli_func_v4 82.54% <ø> (ø)
py_func_v4 80.91% <ø> (ø)
unit 85.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/base.py 100.00% <ø> (+20.85%) ⬆️
gitlab/exceptions.py 100.00% <0.00%> (+0.69%) ⬆️
gitlab/v4/objects/commits.py 94.87% <0.00%> (+1.28%) ⬆️
gitlab/v4/objects/packages.py 96.29% <0.00%> (+1.85%) ⬆️
gitlab/mixins.py 92.22% <0.00%> (+1.94%) ⬆️
gitlab/v4/objects/issues.py 89.15% <0.00%> (+2.40%) ⬆️
gitlab/v4/objects/events.py 98.73% <0.00%> (+2.53%) ⬆️
gitlab/cli.py 100.00% <0.00%> (+3.27%) ⬆️
gitlab/v4/objects/releases.py 100.00% <0.00%> (+3.84%) ⬆️
gitlab/v4/objects/environments.py 100.00% <0.00%> (+4.34%) ⬆️
... and 22 more

We previously converted all string formatting to use f-strings. Enable
pylint check to enforce this.
@nejch nejch merged commit 3d000d3 into main Jun 1, 2022
@nejch nejch deleted the jlvillal/f-string branch June 1, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants