-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backends): use PEP544 protocols for structural subtyping #2442
Conversation
3feb3b7
to
54bbb3f
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2442 +/- ##
==========================================
+ Coverage 91.85% 96.15% +4.29%
==========================================
Files 86 87 +1
Lines 5646 5663 +17
==========================================
+ Hits 5186 5445 +259
+ Misses 460 218 -242
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3e66763
to
99f321a
Compare
a34c5c0
to
0fde7ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lmilbaum, I'm quite slow with the reviews here. Just a small note on keeping things simple for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Can the commit message have some details on the "why" of this PR?
3e6e9e5
to
acf2b49
Compare
/rerun-all |
I still would like to see the description be put into the commit message. At the moment all I see is:
|
/rerun-all |
As an alternative we can squash-merge and it will link to the PR which has much more context than we would usually put in commit messages. WDYT @JohnVillalovos |
That is okay if it is in the commit message. I want the details in the Git log. Not only on GitHub. What if the project gets moved to GitLab in the future. That information can disappear if it isn't in the git repository. Seems relatively easy to take the description above and put it in the commit message. But maybe I am missing something? |
Sure, we can maybe copy it during the squash merge in the description field and it'll appear in the body. I've already sneakily edited the PR title a bit 😺 GitLab's importer is actually quite good these days so it would preserve the commit-to-MR associations, I personally like that over long commit bodies as it includes the review context but that's subjective of course. I'll approve for now, and see if there's anything else to cover :) |
PEP 544 – Protocols: Structural subtyping (static duck typing)
I added the description in the body and reworded a bit during merge, 4afeaff. |
The purpose of this change is to track api changes. For example: package versioning and breaking change announcement in case of protocol change.
This is MVP implementation to be used by #2435
Haven't figured out yet how to implement unit tests for a protocol and its value.