Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add ability to escape at-prefixed parameter #2513

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

pyhedgehog
Copy link
Contributor

@pyhedgehog pyhedgehog commented Mar 9, 2023

Fixes #2511

@codecov-commenter
Copy link

Codecov Report

Merging #2513 (dcd1d50) into main (7d779c8) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2513      +/-   ##
==========================================
- Coverage   96.15%   96.13%   -0.02%     
==========================================
  Files          87       87              
  Lines        5663     5665       +2     
==========================================
+ Hits         5445     5446       +1     
- Misses        218      219       +1     
Flag Coverage Δ
api_func_v4 82.48% <0.00%> (-0.03%) ⬇️
cli_func_v4 82.96% <50.00%> (-0.02%) ⬇️
unit 87.59% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/cli.py 99.27% <50.00%> (-0.73%) ⬇️

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pyhedgehog for this and for adding the tests. LGTM just a small suggestion for the docs.

docs/cli-usage.rst Outdated Show resolved Hide resolved
@JohnVillalovos
Copy link
Member

LGTM. @nejch I'll let you decide when to merge.

@nejch nejch changed the title Fix for GH-2511: Ability to escape at-prefixed parameter fix(cli): add ability to escape at-prefixed parameter Mar 11, 2023
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nejch nejch enabled auto-merge (squash) March 11, 2023 10:03
@nejch nejch merged commit 4f7c784 into python-gitlab:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: Can't escape initial at (@) in parameter
4 participants