Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Note how to use the Docker image from within GitLab CI #2824

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

eddybl
Copy link
Contributor

@eddybl eddybl commented Mar 19, 2024

Ref: #2823

Changes

Improves the main README to give an example as to how to use the Docker image within GitLab CI..

Discussion: #2822
Issue: #2823

Documentation and testing

Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:

@eddybl eddybl force-pushed the improve-documentation-issue2823 branch from d1c2df8 to 6b9b069 Compare March 19, 2024 08:31
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (7ec3189) to head (6b9b069).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2824      +/-   ##
==========================================
- Coverage   96.52%   96.50%   -0.02%     
==========================================
  Files          90       90              
  Lines        5872     5873       +1     
==========================================
  Hits         5668     5668              
- Misses        204      205       +1     
Flag Coverage Δ
api_func_v4 82.22% <ø> (-0.02%) ⬇️
cli_func_v4 83.63% <ø> (+0.05%) ⬆️
unit 88.28% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the docs @eddybl! LGTM, maybe we can sync the version with our tags later so we don't recommend using latest to avoid breaking changes. But not in the scope of this PR maybe.

@nejch nejch enabled auto-merge (rebase) March 27, 2024 08:11
@nejch nejch force-pushed the improve-documentation-issue2823 branch from 6b9b069 to fb09421 Compare March 27, 2024 08:19
@nejch nejch merged commit 6d4bffb into python-gitlab:main Mar 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants