add per_page config option #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpocentek
reviewed
May 23, 2018
| m_open.return_value = fd | ||
| config.GitlabConfigParser('one') | ||
| config.GitlabConfigParser('one') |
There was a problem hiding this comment.
I don't think this duplicated line is useful :) Could you remove it?
There was a problem hiding this comment.
I added this to test the change line#97.
Without the fd.seek(0), all calls to config.GitlabConfigParser fail except the 1st one:
# fd.tell() = 0
config.GitlabConfigParser('one') # reads fd
# fd.tell() = end of file
config.GitlabConfigParser('one') # reads nothing because fd is at end of file, so it failThere was a problem hiding this comment.
OK, thanks for the explanation.
|
LGTM, can you just drop the extra line (see comment). Thanks! |
jouve
commented
May 24, 2018
| m_open.return_value = fd | ||
| config.GitlabConfigParser('one') | ||
| config.GitlabConfigParser('one') |
There was a problem hiding this comment.
I added this to test the change line#97.
Without the fd.seek(0), all calls to config.GitlabConfigParser fail except the 1st one:
# fd.tell() = 0
config.GitlabConfigParser('one') # reads fd
# fd.tell() = end of file
config.GitlabConfigParser('one') # reads nothing because fd is at end of file, so it fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #503 .