Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Implement artifacts deletion #767

Merged
merged 1 commit into from Jun 17, 2019
Merged

feature: Implement artifacts deletion #767

merged 1 commit into from Jun 17, 2019

Conversation

gpocentek
Copy link
Contributor

Closes #744

@max-wittig max-wittig self-assigned this May 9, 2019
@max-wittig
Copy link
Member

max-wittig commented May 9, 2019 •
edited

A line is still to long for the CI pipeline to pass and would you mind rebasing and changing your commit message to match our conventional changelog?

@max-wittig max-wittig assigned gpocentek and unassigned max-wittig May 24, 2019
@max-wittig
Copy link
Member

@gpocentek Would you mind, rebasing or should I take over?

@gpocentek
Copy link
Contributor Author

Sorry for the delay...

max-wittig
max-wittig reviewed Jun 10, 2019
View reviewed changes
gitlab/v4/objects.py Outdated Show resolved Hide resolved
@gpocentek
Copy link
Contributor Author

This requires #791

@gpocentek
Copy link
Contributor Author

I can't reproduce the tests failure locally...

@max-wittig
Copy link
Member

I will merge this now. Tests are passing locally.

@max-wittig max-wittig merged commit 4e1dd27 into master Jun 17, 2019
@max-wittig max-wittig deleted the fix/744/delete_artifacts branch June 17, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig max-wittig left review comments

Assignees

@gpocentek gpocentek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for deleting job artifacts
2 participants
@gpocentek @max-wittig