Skip to content

Commit

Permalink
xfail awkward tests when using numpy 1.25
Browse files Browse the repository at this point in the history
  • Loading branch information
eriknw committed Jun 23, 2023
1 parent f89c72d commit e80eb8a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test_and_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ jobs:
id: coverageAttempt3
if: steps.coverageAttempt2.outcome == 'failure'
# Continue even if it failed 3 times... (sheesh! use codecov instead)
continue-on-error: true
continue-on-error: false
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_FLAG_NAME: ${{ matrix.os }}/${{ matrix.slowtask }}
Expand Down
4 changes: 2 additions & 2 deletions graphblas/tests/test_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ def test_scipy_sparse():


@pytest.mark.skipif("not ak")
@pytest.mark.xfail(reason="Need to investigate test failure")
@pytest.mark.xfail(np.__version__[:5] == "1.25.", reason="awkward bug with numpy 1.25")
def test_awkward_roundtrip():
# Vector
v = gb.Vector.from_coo([1, 3, 5], [20, 21, -5], size=22)
Expand All @@ -391,7 +391,7 @@ def test_awkward_roundtrip():


@pytest.mark.skipif("not ak")
@pytest.mark.xfail(reason="Need to investigate test failure")
@pytest.mark.xfail(np.__version__[:5] == "1.25.", reason="awkward bug with numpy 1.25")
def test_awkward_iso_roundtrip():
# Vector
v = gb.Vector.from_coo([1, 3, 5], [20, 20, 20], size=22)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ line_length = 100
[tool.pytest.ini_options]
minversion = "6.0"
testpaths = "graphblas/tests"
xfail_strict = false # TODO: re-enable this when awkward test failures are fixed
xfail_strict = true
addopts = [
"--strict-config", # Force error if config is mispelled
"--strict-markers", # Force error if marker is mispelled (must be defined in config)
Expand Down

0 comments on commit e80eb8a

Please sign in to comment.