Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare support for Python 3.12 in trove classifiers #389

Merged

Conversation

edgarrmondragon
Copy link
Contributor

No description provided.

@jamadden jamadden merged commit 6bf5e68 into python-greenlet:master Dec 8, 2023
22 checks passed
@jamadden
Copy link
Contributor

jamadden commented Dec 8, 2023

Thanks, I don't know how I missed that.

@mgorny
Copy link

mgorny commented Dec 8, 2023

Is it supported though? Bug #368 suggests that it's broken.

@edgarrmondragon edgarrmondragon deleted the pypi-metadata-cp312 branch December 8, 2023 18:12
@edgarrmondragon
Copy link
Contributor Author

Is it supported though? Bug #368 suggests that it's broken.

Right. I can confirm that's still present on the debug build of latest 3.12.

@jamadden
Copy link
Contributor

jamadden commented Dec 8, 2023

Yes, that's a known issue --- one of several on 3.12. I don't expect them to affect most people, and the greenlet tests, as well as gevent's very extensive test suite, all pass on 3.12.

@mgorny
Copy link

mgorny commented Dec 8, 2023

The tests don't pass — they crash on assertions:

test_trace_events_multiple_greenlets_switching (greenlet.tests.test_tracing.TestPythonTracing.test_trace_events_multiple_greenlets_switching) ... python: Python/instrumentation.c:956: call_instrumentation_vector: Assertion `code->_co_instrumentation_version == tstate->interp->monitoring_version' failed.
py312: exit -6 (26.15 seconds) /tmp/greenlet> python -m unittest discover -v greenlet.tests pid=22112
.pkg: _exit> python /usr/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
  py312: FAIL code -6 (45.48=setup[19.31]+cmd[0.02,26.15] seconds)
  evaluation failed :( (45.71 seconds)

@jamadden
Copy link
Contributor

jamadden commented Dec 8, 2023

In a debug build of Python, yes, they crash. But most people aren't using a debug build of Python.

@mgorny
Copy link

mgorny commented Dec 8, 2023

I don't understand why people don't use debug builds on CI. Don't they want to know about breakage that's not visible in release builds? (such as API violations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants