Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cms_toolbars.py #536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update cms_toolbars.py #536

wants to merge 1 commit into from

Conversation

vrac10
Copy link

@vrac10 vrac10 commented Jan 18, 2023

Description

Currently, the default argument list 'action_args' accumulates the data from previous executions. This pull request makes sure that the default argument always has an empty list as intended.

Fixes #535

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Calling the function again and testing it shows that the previous execution data isn't accumulated in the default
    parameter

Checklist:

  • My code follows the style guidelines of this project
  • I have not added a commit to any .db files as part of my pull request
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@botanicvelious
Copy link
Collaborator

@warthog9 what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default argument initialization with list found which is a loop hole in python
2 participants