Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization for thousand in zh_CN #126

Closed
dofine opened this issue Jul 4, 2023 · 1 comment · Fixed by #127
Closed

Add localization for thousand in zh_CN #126

dofine opened this issue Jul 4, 2023 · 1 comment · Fixed by #127

Comments

@dofine
Copy link
Contributor

dofine commented Jul 4, 2023

I forked the repo and edited localization for thousand in zh_CN (while wondering why it was not localized before), see dofine@c6eaf06 .
But as a newbie, I don't know how to test it and get merged. :( Maybe someone could give some help.

@hugovk
Copy link
Member

hugovk commented Jul 4, 2023

Hello!

Here's instructions from GitHub on how to create what's called a "pull request", or PR, which is how to propose changes to the project:

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

For example, you can go to:

main...dofine:humanize:main

And then fill out the template with your changes.

If you include the magic phrase "Fixes #126" then when the PR is merged, it will automatically close this issue.

Then click "Create pull request", and it will then start some automated testing.

Let me know if you need any more help.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants