Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest metric prefixes: ronna, ronto, quetta, quecto #78

Merged
merged 4 commits into from Dec 27, 2022

Conversation

H4ckerxx44
Copy link
Contributor

@H4ckerxx44 H4ckerxx44 commented Dec 26, 2022

  • Add missing SI-prefixes

Changes proposed in this pull request:
Due to the fact that humanize is missing the prefixes added on the 27th meeting of the CGPM (Conférence générale des poids et mesures), I decided to add those to the metric() method as well as the tests.

The new prefixes can be found here or as I have listed below.

  • Quetta: $10^{30}$
  • Ronna: $10^{27}$
  • ronto: $10^{-27}$
  • quecto: $10^{-30}$

@hugovk hugovk added the changelog: Added For new features label Dec 26, 2022
@hugovk
Copy link
Member

hugovk commented Dec 26, 2022

Thank you!

Please could you fix the tests, and add a test case for quetta/Q?

@H4ckerxx44
Copy link
Contributor Author

Thank you!

Please could you fix the tests, and add a test case for quetta/Q?

Should be done.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #78 (53e35a9) into main (79c240d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files           9        9           
  Lines         741      741           
=======================================
  Hits          735      735           
  Misses          6        6           
Flag Coverage Δ
macos-latest 97.57% <100.00%> (ø)
ubuntu-latest 97.57% <100.00%> (ø)
windows-latest 96.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_number.py 100.00% <ø> (ø)
src/humanize/number.py 96.96% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hugovk hugovk changed the title feat: add latest metric prefixes Add latest metric prefixes: ronna, ronto, quetta, quecto Dec 27, 2022
@hugovk hugovk merged commit c730de5 into python-humanize:main Dec 27, 2022
@hugovk
Copy link
Member

hugovk commented Dec 27, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants