Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more pylint cleanup #151

Merged
merged 15 commits into from
Apr 4, 2023
Merged

Even more pylint cleanup #151

merged 15 commits into from
Apr 4, 2023

Conversation

yut23
Copy link
Collaborator

@yut23 yut23 commented Apr 4, 2023

The only warnings left are:
cyclic-import: fixing these would require some package restructuring
duplicate-code: there are lots of slightly modified functions all over the place; we may want to just disable this
unused-argument: the remaining instances need a better understanding of the solvers than I have right now

@yut23 yut23 changed the title Fix pylint arguments-differ warnings Even more pylint cleanup Apr 4, 2023
@yut23 yut23 marked this pull request as ready for review April 4, 2023 02:37
@zingale zingale merged commit d1a8c9c into python-hydro:main Apr 4, 2023
10 checks passed
@yut23 yut23 deleted the more_cleanup branch April 5, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants