Fixed to read out all data from socket when Data Frame payload is qui…

…te large like SETTINGS_MAX_FRAME_SIZE

hyper/http20/connection.py

@@ -483,11 +483,35 @@ def _consume_single_frame(self):
         frame, length = Frame.parse_frame_header(header)
 
         # Read the remaining data from the socket.
+        data = self._recv_payload(length)
+        self._consume_frame_payload(frame, data)
+
+    def _recv_payload(self, length):
         if length:
             data = self._sock.recv(length)
         else:
             data = memoryview(b'')
 
+        data_length = len(data)
+        if data_length < length:
+            _buffer = bytearray(length)
+            _buffer_view = memoryview(_buffer)
+            _end = data_length
+            _buffer_view[0:_end] = data.tobytes()
+            while data_length < length:
+                # Read remaining payload if it hasn't been read all at a time.
+                length -= data_length
+                _data = self._sock.recv(length)
+                data_length = len(_data)
+                if data_length == 0:
+                    break
+                _buffer_view[_end:_end + data_length] = _data.tobytes()
+                _end += data_length
+            data = _buffer_view[0:_end]
+
+        return data
+
+    def _consume_frame_payload(self, frame, data):
         frame.parse_body(data)
 
         log.info(

test/test_hyper.py

@@ -1072,6 +1072,23 @@ def test_we_can_read_from_the_socket(self):
         s = c.recent_stream
         assert s.data == [b'testdata']
 
+    def test_we_can_read_fitfully_from_the_socket(self):
+        sock = DummyFitfullySocket()
+        sock.buffer = BytesIO(
+            b'\x00\x00\x18\x00\x01\x00\x00\x00\x01'
+            b'testdata'
+            b'+payload'
+        )
+
+        c = HTTP20Connection('www.google.com')
+        c._sock = sock
+        c.putrequest('GET', '/')
+        c.endheaders()
+        c._recv_cb()
+
+        s = c.recent_stream
+        assert s.data == [b'testdata+payload']
+
     def test_putrequest_sends_data(self):
         sock = DummySocket()
 
@@ -2045,6 +2062,15 @@ def recv(self, l):
     def close(self):
         pass
 
+
+class DummyFitfullySocket(DummySocket):
+    def recv(self, l):
+        length = l
+        if l != 9 and l >= 4:
+            length = int(round(l / 2))
+        return memoryview(self.buffer.read(length))
+
+
 class DummyStream(object):
     def __init__(self, data, trailers=None):
         self.data = data