Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

Implement transparent request body decoding. #20

Closed
Lukasa opened this issue Feb 16, 2014 · 10 comments
Closed

Implement transparent request body decoding. #20

Lukasa opened this issue Feb 16, 2014 · 10 comments
Labels

Comments

@Lukasa
Copy link
Member

Lukasa commented Feb 16, 2014

HTTP/2.0 mandates that all user-agents be able to handle encoded request and response bodies. We should steal the transparent handling from @shazow, like the dirty thieves we are.

@shazow
Copy link

shazow commented Feb 16, 2014

I will require a percentage of your revenues as compensation.

@sigmavirus24
Copy link
Contributor

5% of 0 is still 100, right?

@shazow
Copy link

shazow commented Feb 16, 2014

I believe ∞ is the amount.

@sigmavirus24
Copy link
Contributor

No that would be 100/0. Silly @shazow leave the math to the mathemagicians.

@Lukasa
Copy link
Member Author

Lukasa commented Feb 16, 2014

@shazow Does my current Gittiping of you cover it? =D

@shazow
Copy link

shazow commented Feb 16, 2014

@Lukasa Your Briefmetrics subscription certainly does. ;)

@Lukasa
Copy link
Member Author

Lukasa commented Feb 16, 2014

Nope, I'm paying for Briefmetrics because I use it, not as a reciprocal gesture. =)

@shazow
Copy link

shazow commented Feb 16, 2014

[Like]

@Lukasa
Copy link
Member Author

Lukasa commented Feb 18, 2014

I'm not convinced that doing this in hyper itself is a good thing. I wonder if the better place to do it is in the HTTP20Adapter, by monkeypatching the HTTP20Response object.

@Lukasa
Copy link
Member Author

Lukasa commented Feb 20, 2014

Implemented in c47cfd3. I remain unconvinced that this is something we should be doing in hyper, but for now I'm going ahead with it.

@Lukasa Lukasa closed this as completed Feb 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants