Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

Include licenses for the code I've borrowed. #35

Closed
Lukasa opened this issue Apr 4, 2014 · 3 comments
Closed

Include licenses for the code I've borrowed. #35

Lukasa opened this issue Apr 4, 2014 · 3 comments

Comments

@Lukasa
Copy link
Member

Lukasa commented Apr 4, 2014

I've borrowed a pair of chunks of code (SocketServerThread in the tests and DeflateDecoder in the response) from @shazow's urllib3 project. Technically the MIT license requires that I distribute it along with that code, which I should really do. =)

@Lukasa
Copy link
Member Author

Lukasa commented Apr 4, 2014

I also think @alekstorm has grabbed some code from the Python standard library and from CherryPy: I should add those licenses as well.

@shazow
Copy link

shazow commented Apr 4, 2014

IMO just shove them all in a single file. The license file headers thing is kinda BS anyways (I've been meaning to strip them from urllib3).

@Lukasa
Copy link
Member Author

Lukasa commented Apr 5, 2014

Yeah, I think I'll add a NOTICES file and then reference it from the relevant functions.

@Lukasa Lukasa closed this as completed Apr 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants