Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

Certificates for Windows #9

Closed
Lukasa opened this issue Feb 11, 2014 · 3 comments
Closed

Certificates for Windows #9

Lukasa opened this issue Feb 11, 2014 · 3 comments

Comments

@Lukasa
Copy link
Member

Lukasa commented Feb 11, 2014

In tls.py we use SSLContext.set_default_verify_paths() to get the system certificate bundle. This works fine on my OS X development box, but leads to cert verification errors on Windows.

Options are either to use a Windows-specific version as well that we know will work, or to start bundling requests' CAcerts.

@Lukasa
Copy link
Member Author

Lukasa commented Feb 21, 2014

Ok, I've fixed this by using the same certificate package as Requests uses. @kennethreitz, are you ok with cross-project use like this? I'm grabbing it from your CI server. If you aren't happy, let me know and I'll work out an alternative.

In the meantime, closing.

@Lukasa Lukasa closed this as completed Feb 21, 2014
@kennethreitz
Copy link

By all means! Ideally, I'd like to have a more proper domain/project setup for this. I'll get around to that eventually in conjunction with @dstufft :)

In the meantime, just grab away, or depend on certifi :)

@Lukasa
Copy link
Member Author

Lukasa commented Feb 22, 2014

@kennethreitz Awesome, thanks! =) If you ever need a hand sorting that out, I've got a barely-used Digital Ocean server that I'm happy to devote to the cause.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants