Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install IDNA tables file. #134

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Install IDNA tables file. #134

merged 2 commits into from
Sep 25, 2020

Conversation

wsanchez
Copy link
Contributor

Install the IDNA tables file.

On trying to switch Klein to use the Hypothesis strategies now provided by Hyperlink, I got build failures due to the file being missing.

I though that tox -e packaging would notice this was missing, but it doesn't catch it.

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          13       13           
  Lines        1809     1809           
  Branches      209      209           
=======================================
  Hits         1785     1785           
  Misses         12       12           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea81297...2f955b4. Read the comment docs.

Copy link
Member

@mahmoud mahmoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that packaging doesn't catch this! Given that it doesn't, should we have include_package_data as a catch-all or do we want to keep with the remembering-to-explicitly-add?

@wsanchez
Copy link
Contributor Author

Weird that packaging doesn't catch this!

Yeah I had the same thought…

Given that it doesn't, should we have include_package_data as a catch-all or do we want to keep with the remembering-to-explicitly-add?

I'm not sure. It's rare, but now we need a release, which is annoying. That said, I'd hate to package a thing we didn't mean to. Dunno.

@wsanchez wsanchez merged commit 0d8b630 into master Sep 25, 2020
@wsanchez wsanchez deleted the install-idna-tables branch September 25, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants