Use Hyperlink's Hypothesis strategies #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is failing due to a missing file from Hyperlink. I've opened a PR for that: python-hyper/hyperlink#134 |
|
OK, hyperlink has a fix on master |
# Conflicts: # src/klein/test/_strategies.py
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 98.66% 98.64% -0.02%
==========================================
Files 46 45 -1
Lines 3884 3850 -34
Branches 252 249 -3
==========================================
- Hits 3832 3798 -34
Misses 36 36
Partials 16 16
Continue to review full report at Codecov.
|
wsanchez
commented
Sep 26, 2020
| @@ -36,6 +54,59 @@ | |||
| __all__ = () | |||
|
|
|||
|
|
|||
| T = TypeVar("T") | |||
There was a problem hiding this comment.
This section moved here; wasn't needed by Hyperlink.
wsanchez
commented
Sep 26, 2020
|
|
||
| attrs==20.1.0 | ||
| hyperlink==20.0.1 |
There was a problem hiding this comment.
Until the next Hypothesis release.
twm
approved these changes
Dec 26, 2020
| @@ -33,10 +33,10 @@ deps = | |||
| tw1910: Twisted==19.10.0 | |||
| tw203: Twisted==20.3.0 | |||
| twcurrent: Twisted | |||
| twtrunk: https://github.com/twisted/twisted/archive/trunk.zip | |||
| twtrunk: git+git://github.com/twisted/twisted@trunk#egg=Twisted | |||
There was a problem hiding this comment.
Why change this from the archive form?
* master: (33 commits) [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update http ➜ https Move comment to what it's referring to Fix fragile line numbers Copyright dance [requires.io] dependency update Update MANIFEST.in ignore these flake8 errors that make no sense re-order in a way that seems logical today Fix up the not-type-checking signatures for Arg, KwArg, VarArg, DefaultNamedArg tox -e lint should probably actually run something Move check-manifest to pre-commit Quote repo versions Fix packaging Update needs: parameter Disable lint job for a sec ... # Conflicts: # src/klein/test/_strategies.py
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jun 20, 2021
Most of patches are home-grown instead of from upstream, as upstream fixes are quite large and cannot be cleanly backported. Specifically, upstream moves test strategies from Klein to Hyperlink [1] and drop Python 2.x support [2,3]. The fix for Werkzeug 2.x in test_resource.py [3] is smaller, while it cannot be cleanly backported, either. [1] twisted/klein#393 [2] twisted/klein#328 [3] twisted/klein#355 [4] twisted/klein#499 git-svn-id: file:///srv/repos/svn-community/svn@965883 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jun 20, 2021
Most of patches are home-grown instead of from upstream, as upstream fixes are quite large and cannot be cleanly backported. Specifically, upstream moves test strategies from Klein to Hyperlink [1] and drop Python 2.x support [2,3]. The fix for Werkzeug 2.x in test_resource.py [3] is smaller, while it cannot be cleanly backported, either. [1] twisted/klein#393 [2] twisted/klein#328 [3] twisted/klein#355 [4] twisted/klein#499 git-svn-id: file:///srv/repos/svn-community/svn@965883 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Hypothesis strategies that are now provided by Hyperlink, remove them from Klein.
These were copied there from Klein to make them more available to projects and manage them with Hyperlink itself.