Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved chars escaping is not compatible with what browsers do #18

Open
kmike opened this issue Jun 26, 2017 · 2 comments
Open

reserved chars escaping is not compatible with what browsers do #18

kmike opened this issue Jun 26, 2017 · 2 comments

Comments

@kmike
Copy link

kmike commented Jun 26, 2017

This is weird, but browsers don't usually escape |; Chrome only escapes it in URL path, but not in query; Firefox doesn't escape it at all. See scrapy/w3lib#25 (comment).

@mahmoud
Copy link
Member

mahmoud commented Jul 3, 2017

That's a pretty cool survey of browser behavior you've got in there! It also keenly demonstrates the moving target with trying to emulate browsers. That said I've got some ideas of how to achieve similar behavior, related to #28. In short, make these global behaviors customizable based on a context. It'll probably come after we get a more modern IDNA approach, but it's definitely on the roadmap! :)

@glyph
Copy link
Collaborator

glyph commented Apr 28, 2021

(I'd be really interested to see what the WHATWG URL spec says browsers should be doing, here…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants