Bugfix Python 3: defining __eq__ disables __hash__ inheritance
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Python3 `__eq__` disables inheritance of `__hash__`
agoose77
changed the title
__eq__ disables __hash__ inheritance
|
Hi there, what bugs does this cause? |
|
In python 2, we can use uri references as dict keys, not in python 3
…On Mon, 9 Jul 2018, 13:18 Ian Stapleton Cordasco, ***@***.***> wrote:
Hi there, what bugs does this cause?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMMncVJyJzIm1nlq3LUs9leTAJAaoPsks5uE0oPgaJpZM4VHd1K>
.
|
|
Closing & re-opening to trigger a rebuild with Travis CI |
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 688 691 +3
=====================================
+ Hits 688 691 +3
Continue to review full report at Codecov.
|
|
I added e1fedef because of https://travis-ci.org/python-hyper/rfc3986/jobs/463331503#L479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Python3
__eq__disables inheritance of__hash__