Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #184

Merged
merged 10 commits into from
Apr 12, 2023
Merged

Fix CI #184

merged 10 commits into from
Apr 12, 2023

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Apr 11, 2023

@njsmith
Copy link
Member Author

njsmith commented Apr 11, 2023

......okay so this is a mess. As far as I can tell:

  • wsaccel has dropped support for python 2
  • autobahn testsuite still depends on python 2
  • autobahn testsuite requires wsaccel. so even if we install python 2, a simple pip install autobahntestsuite still fails.
  • autobahn testsuite is unmaintained
  • wsaccel is also unmaintained (the pypi page has a note at the top stating that this is because autobahn is unmaintained)

I think at this point we should give up on running the autobahn tests. They were really useful when we were bootstrapping to get confidence that we had things working at all, but at this point they're just breaking our CI and we've had plenty of times we've had to work around issues with them -- I don't really trust them for correctness any more than our code/tests.

@njsmith
Copy link
Member Author

njsmith commented Apr 11, 2023

(we should also figure out if we want to do anything about our own wsaccel dependency, but that's a whole other issue)

autobahntestsuite is abandoned, only runs on python 2, and has
dependencies like wsaccel that are *also* abandoned and *don't* run on
python 2. we could probably keep it limping along for a while with
enough effort, but I don't think it's worth it.
@njsmith njsmith changed the title Fix tox config, and add newer pythons to CI Fix CI Apr 11, 2023
@njsmith
Copy link
Member Author

njsmith commented Apr 11, 2023

OK! I think this PR is finally ready!

@Kriechi I see you reviewed this just before I made the most-potentially-controversial change (removing autobahn), so I'll wait a bit to merge to give you (or anyone else) a chance to weigh in on that :-) (also b/c this currently isn't blocking anything AFAIK)

Copy link
Member

@Kriechi Kriechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved! 👍

@njsmith njsmith merged commit c0a1079 into python-hyper:main Apr 12, 2023
@njsmith njsmith deleted the update-tox branch April 12, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants