-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #184
Fix CI #184
Conversation
......okay so this is a mess. As far as I can tell:
I think at this point we should give up on running the autobahn tests. They were really useful when we were bootstrapping to get confidence that we had things working at all, but at this point they're just breaking our CI and we've had plenty of times we've had to work around issues with them -- I don't really trust them for correctness any more than our code/tests. |
(we should also figure out if we want to do anything about our own wsaccel dependency, but that's a whole other issue) |
autobahntestsuite is abandoned, only runs on python 2, and has dependencies like wsaccel that are *also* abandoned and *don't* run on python 2. we could probably keep it limping along for a while with enough effort, but I don't think it's worth it.
OK! I think this PR is finally ready! @Kriechi I see you reviewed this just before I made the most-potentially-controversial change (removing autobahn), so I'll wait a bit to merge to give you (or anyone else) a chance to weigh in on that :-) (also b/c this currently isn't blocking anything AFAIK) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved! 👍
And hopefully will fix test failures like https://github.com/python-hyper/wsproto/actions/runs/4462959392/jobs/8252677125?pr=183