Gets us to 100% test coverage on wsproto.frame_protocol. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweeeeeet flake8 is complaining for some reason |
njsmith
approved these changes
Jun 2, 2017
There was a problem hiding this comment.
Looks good to me.
I noticed that parse_more_gen still has some stray code to filter enabled extensions, which is now redundant. Could make it a separate PR, but if I did it now it'd probably conflict with this so mentioning it and you can do it or hopefully I'll remember :-)
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 86.06% 87.98% +1.91%
==========================================
Files 7 7
Lines 847 849 +2
Branches 186 184 -2
==========================================
+ Hits 729 747 +18
+ Misses 76 68 -8
+ Partials 42 34 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25, addresses #26.