New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Buildkite pipeline schema #198
Comments
Right now, the only schemas included are listed in schemastore. I'm not strictly against adding something else, but it makes things easier for me if I can point at them as my "source of truth". I therefore come to you with a request back, so that I can fulfill this, that you get Buildkite added to schemastore. Schemastore is pretty easygoing about new schemas. They'll generally ask that you do the work of adding one, but it's not very hard. Since this one is hosted on GitHub, you'll basically just need to add a link and description to their catalog. Here's an example block which defines a github-hosted schema for angular: To explain a little bit why it helps:
If you don't feel comfortable or able to add the schema to schemastore, I'll try to get to it, but I'm pretty swamped with work right now, so no promises on timeline. |
It is in schemastore: For reasons I don't understand, it's just not hosted on the schemastore website. |
馃う Sorry about that! I had searched, but missed it! Maybe I looked for I'll work on pulling this in when I'm next able. |
1. Add Buildkite to the catalog 2. Add a test-case from the Buildkite repo 3. Fix minor issues in the vendor-schemas script - bugfix KeyError when adding new schemas - strip trailing whitespace so that pre-commit run doesn't munge hash comparison 4. Update generate-hooks-config script to handle 'types_or' 5. Run vendor-schemas and generate-hooks-config Resolves #198
1. Add Buildkite to the catalog 2. Add a test-case from the Buildkite repo 3. Fix minor issues in the vendor-schemas script - bugfix KeyError when adding new schemas - strip trailing whitespace so that pre-commit run doesn't munge hash comparison 4. Update generate-hooks-config script to handle 'types_or' 5. Run vendor-schemas and generate-hooks-config Resolves #198
1. Add Buildkite to the catalog 2. Add a test-case from the Buildkite repo 3. Fix minor issues in the vendor-schemas script - bugfix KeyError when adding new schemas - strip trailing whitespace so that pre-commit run doesn't munge hash comparison 4. Update generate-hooks-config script to handle 'types_or' 5. Run vendor-schemas and generate-hooks-config Resolves #198
1. Add Buildkite to the catalog 2. Add a test-case from the Buildkite repo 3. Fix minor issues in the vendor-schemas script - bugfix KeyError when adding new schemas - strip trailing whitespace so that pre-commit run doesn't munge hash comparison 4. Update generate-hooks-config script to handle 'types_or' 5. Run vendor-schemas and generate-hooks-config Resolves #198
I've just released v0.20.0 which includes this. 馃コ Please let me know if you run into any issues using it, and thanks for putting in the request! |
As a user of Buildkite, I would super appreciate it if their pipeline schema was bundled with check-jsonschema 馃檹
https://github.com/buildkite/pipeline-schema/
The text was updated successfully, but these errors were encountered: