Add new --disable-formats flag to replace --disable-format
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'--disable-formats' disables any given format string, and can be passed multiple times. '--disable-format' is deprecated. '--disable-formats "*"' can be used to disable all formats -- and in the implementation, it has slightly different behavior from disabling the full list of known formats.
Docs for the new option, a changelog entry, and a minor fix to some helptext.
|
Hm. In #231 I wrote this down as a comma-delimited list, and here I implemented it as a multi-use option. |
Minor refactor, no new or changed code -- just renames.
- Convert to a custom metavar and a nicely printed list in the helptext - Use a new CommaDelimitedList type to capture comma delimited args, then join the results to keep the tuple of strings type which is desired. Add new test cases for this.
for more information, see https://pre-commit.ci
|
Fixed it by adding comma-delimited-list parsing and allowing that combined with the multi-argument usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--disable-formats "*"will replace--disable-format(deprecated).--disable-formats regexis an alternative to--format-regex disabled, but that usage is not deprecated yet (I'm unusre if it should be).--disable-formats uri-reference --disable-formats email --disable-formats ipv4is new behavior to disable specific checks.--disable-formatwill warn when used, but is still effective.