Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add vendor bitbucket pipelines #282

Merged
merged 3 commits into from Jul 11, 2023
Merged

Feature/add vendor bitbucket pipelines #282

merged 3 commits into from Jul 11, 2023

Conversation

djgoku
Copy link
Contributor

@djgoku djgoku commented Jul 7, 2023

No description provided.

@sirosen
Copy link
Member

sirosen commented Jul 10, 2023

Hi, thanks for submitting this!

The CI issues aren't related to your work -- some dependency updates have put us in a bad state in which main fails CI right now. I'll try to make time in the next few days to fix this, and then we can get CI passing on this and merge it.

(In terms of your work here, no notes! It looks good. But I want the confirmation from CI that I'm not missing anything.)

@djgoku
Copy link
Contributor Author

djgoku commented Jul 11, 2023

Thank you for the review!

Is there anything I can possibly help with?

@sirosen
Copy link
Member

sirosen commented Jul 11, 2023

I appreciate the offer. In this case, I think you've already provided the most important thing, which is energy and attention put into the project! I've already put together a patch to get CI back in working shape and merged it (#284).

Would you be willing to rebase to pick up those fixes?

@djgoku djgoku force-pushed the feature/add-vendor-bitbucket-pipelines branch from dab2b93 to f330ea6 Compare July 11, 2023 15:34
@djgoku
Copy link
Contributor Author

djgoku commented Jul 11, 2023

Would you be willing to rebase to pick up those fixes?

Done!

@sirosen sirosen merged commit 99439e9 into python-jsonschema:main Jul 11, 2023
22 checks passed
sirosen added a commit that referenced this pull request Jul 11, 2023
@sirosen
Add changelog entry for #282
b83649d
@sirosen
Copy link
Member

sirosen commented Jul 11, 2023

This should now be available in v0.23.3, and I've made sure to credit you in the changelog! 😄

Please let me know if you see any issues with it.

@djgoku djgoku deleted the feature/add-vendor-bitbucket-pipelines branch July 11, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djgoku @sirosen