Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taskfile validation hook #417

Merged

Conversation

jrdnbradford
Copy link
Contributor

Any interest in adding this hook? Task is a cross-platform tool used to run tasks that is often used in CI, so it seems to fit with many of the hooks related to build pipelines in this repo.

@sirosen
Copy link
Member

sirosen commented Apr 10, 2024

This seems great, and like you say, a good fit! Thanks for the contribution!
I need to make sure to read up on this to double-check the patterns used, etc, before merging, which will take me some time after my work day. Assuming no issues, I'll get this in and do a release soon.

@jrdnbradford
Copy link
Contributor Author

@sirosen awesome, let me know if I can do anything else on this. On a personal note I've been migrating my Makefiles to Taskfiles and have been very happy with the results.

Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job; thanks much for the contribution!

I'll make sure to give you your kudos in the changelog. Feel free to suggest schemas for other tools which you're using in the future.

.pre-commit-hooks.yaml Show resolved Hide resolved
@sirosen sirosen merged commit 5a80940 into python-jsonschema:main Apr 10, 2024
23 checks passed
@jrdnbradford jrdnbradford deleted the add-taskfile-validation branch April 10, 2024 23:04
@jrdnbradford
Copy link
Contributor Author

Awesome, glad to help with this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants