Skip to content

Commit

Permalink
Shorten the protocol test.
Browse files Browse the repository at this point in the history
  • Loading branch information
Julian committed Dec 15, 2021
1 parent 5b4d5b7 commit 0878727
Showing 1 changed file with 3 additions and 15 deletions.
18 changes: 3 additions & 15 deletions jsonschema/tests/test_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -1423,6 +1423,9 @@ def test_enum_allows_non_unique_items(self):


class ValidatorTestMixin(MetaSchemaTestsMixin, object):
def test_it_implements_the_validator_protocol(self):
self.assertIsInstance(self.Validator({}), protocols.Validator)

def test_valid_instances_are_valid(self):
schema, instance = self.valid
self.assertTrue(self.Validator(schema).is_valid(instance))
Expand Down Expand Up @@ -2134,21 +2137,6 @@ def test_helpful_error_message_on_failed_pop_scope(self):
self.assertIn("Failed to pop the scope", str(exc.exception))


class TestValidatorProtocol(TestCase):
def test_each_validator_is_instance_of_protocol(self):
schema = {}
for validator_cls in [
validators.Draft3Validator,
validators.Draft4Validator,
validators.Draft6Validator,
validators.Draft7Validator,
validators.Draft201909Validator,
validators.Draft202012Validator,
]:
validator = validator_cls(schema)
assert isinstance(validator, protocols.Validator)


def sorted_errors(errors):
def key(error):
return (
Expand Down

0 comments on commit 0878727

Please sign in to comment.