Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak in validation #237

Closed
minrk opened this issue Jun 29, 2015 · 2 comments
Closed

memory leak in validation #237

minrk opened this issue Jun 29, 2015 · 2 comments

Comments

@minrk
Copy link

minrk commented Jun 29, 2015

this gist includes a large JSON file and script that opens and validates it repeatedly. Each validation appears to permanently increase the memory footprint, at least on Python 3.4.

To run the test:

git clone https://gist.github.com/a72d0291702d4fca1b66.git test-leak
cd test-leak
python3 test-schema.py

The script loads a JSON file a few times, showing that only the first load increases the memory footprint. Then it goes through the same loop, also validating the notebook on each iteration, showing that memory increases on each validation:

jsonschema-2.4.0
pid: 90109
    baseline     20MB
      opened    127MB
      opened    127MB
      opened    127MB
      opened    127MB
      opened    127MB
   validated    235MB
   validated    397MB
   validated    558MB
   validated    720MB
   validated    882MB
@minrk
Copy link
Author

minrk commented Jun 29, 2015

My apologies. It looks like this is fixed in current jsonschema-2.5.1. Thanks for fixing it!

@minrk minrk closed this as completed Jun 29, 2015
@Julian
Copy link
Member

Julian commented Jun 29, 2015

:) glad it works.
On Jun 29, 2015 5:55 PM, "Min RK" notifications@github.com wrote:

My apologies. It looks like this is fixed in current jsonschema-2.5.1.
Thanks for fixing it!


Reply to this email directly or view it on GitHub
#237 (comment).

Julian added a commit that referenced this issue Sep 2, 2018
002ce0f Merge pull request #237 from leadpony/add_to_list
6e62399 Add Justify as a suite user to README.md
0436e52 Merge pull request #233 from leadpony/fix_indentation
c09e3a6 Fix broken indentation in enum.json
353f7f3 Merge pull request #232 from Clemens-U/master
aa833c5 Added a test for an invalid closing Z after time-zone offset for date-time format.
c17161a Merge pull request #230 from Jokipii/master
139fb66 Add https://github.com/seznam/python-fastjsonschema to the list

git-subtree-dir: json
git-subtree-split: 002ce0fbe070f483429260188b18fe07bd6ec0f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants