Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean schemas are incorrectly leaked backwards into previous drafts #523

Closed
Julian opened this issue Jan 26, 2019 · 1 comment
Closed

Boolean schemas are incorrectly leaked backwards into previous drafts #523

Julian opened this issue Jan 26, 2019 · 1 comment
Labels
Bug Something doesn't work the way it should. Needs Test Upstream Issues that need to have a test added to https://github.com/json-schema-org/JSON-Schema-Test-Suite

Comments

@Julian
Copy link
Member

Julian commented Jan 26, 2019 •
edited
Loading

The relevant test cases here are these, which are currently marked skipped but should not be (they currently fail).

Probably we need to add a validator_functions_of argument to jsonschema.validators.create that, given a schema, returns an iterable of validator functions (which then permits booleans on Draft6/7 and not on earlier ones), but doing so is actually a bit tricky...
@Julian Julian added this to the v3.0.0 milestone Jan 26, 2019
@Julian
Copy link
Member Author

Julian commented Jan 28, 2019

Ugly as sin branch that at least passes the tests is https://github.com/Julian/jsonschema/tree/no-leaking-boolean-schemas

@Julian Julian mentioned this issue Feb 8, 2019
Closed
@Julian Julian added the Bug Something doesn't work the way it should. label Feb 16, 2019
@Julian Julian modified the milestones: v3.0.0, v3.1.0 Feb 24, 2019
@Julian Julian added the Needs Test Upstream Issues that need to have a test added to https://github.com/json-schema-org/JSON-Schema-Test-Suite label Sep 4, 2019
Julian added a commit that referenced this issue Oct 19, 2021
@Julian
Squashed 'json/' changes from 54440eab4..ba3a90534
4ecbea5 
ba3a90534 Merge pull request #523 from olegshtch/extendible-schema-test-suite
458e7ac1e Add test suite to test dynamic reference and anchor link and their independency of order
fe405a119 draft/future -> draft/next in $refs also
3d9d35a2a Merge pull request #522 from json-schema-org/ether/draft-next
11b5076f0 rename draft-future to draft-next
0245dcc94 Merge pull request #521 from olegshtch/add-recursive-ref-test-suite
e9fb9cf45 Merge pull request #517 from ChALkeR/chalker/date-time-leap
f1b230c69 Add test from Appendix C.  Example of recursive schema extension of the draft.
bb2e37317 Test date-time with leap second on a wrong hour/minute
8b797cfe6 Merge pull request #520 from json-schema-org/ether/custom-dialect
5d23f3112 Add tests for invalid date-time past leap second
63f8e93c1 Improve leap seconds test in optional/format/date-time
3d00f593d test the use of the $vocabulary keyword in a custom metaschema

git-subtree-dir: json
git-subtree-split: ba3a9053400dd6237aef9cc63601758b1d266818
@Julian Julian removed this from the v3.2.0 milestone Aug 21, 2022
@Julian Julian closed this as completed in 8c4cd7c Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something doesn't work the way it should. Needs Test Upstream Issues that need to have a test added to https://github.com/json-schema-org/JSON-Schema-Test-Suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Julian