Add support for json-pointer references based on Chase Sterling's code. #37
Conversation
|
Hi :)! When you say latest, what do you mean by that :)? Has draft 3 been revised recently here? |
|
I had meant the latest changes to the Draft3Validator class, his branch
|
|
Ah! Great, gotcha, thanks :) I'll take a look. |
| try: | ||
| return self._schema | ||
| except AttributeError: | ||
| return None |
There was a problem hiding this comment.
Is there a reason this is here? I don't think it should be necessary. Do you have a case where you got an AttributeError?
There was a problem hiding this comment.
Yea, L411-L415 uses it - Maybe I made have made some invalid assumptions there?
There was a problem hiding this comment.
Well, self.schema is set in __init__, which means in turn that _schema should be present by the time anything wants it.
There was a problem hiding this comment.
Humm - Well, It's certainly possible I've made a mistake somewhere!
But - I'm fairly confident validate_ref was being called before _schema was set.
I'll re-check as soon as I can today
There was a problem hiding this comment.
Oh. OK good I just wanted to check that that was the case, if it is I bet the reason why it was being called was during the meta-validation, so I think for that maybe we should just have META_SCHEMA be the default for _schema since that's going to be what's expected there.
Hopefully I'll get a chance to merge this tonight.
|
So, thanks again for this. After taking a quick look while cleaning this up a tiny bit, the minimum amount to make all of the tests here pass is what I have put in the json-ref branch here. I don't doubt that the |
Add back support for decoding them. refs python-jsonschema#37
…pointer references. refs python-jsonschema#37
|
Ok, added the decoding back in along with tests. These are from section 4 and 6 of the json pointer specification |
Hiya,
I've updated Chase Sterling's code discussed in issue #23 for the latest changes to JSONSchema. I figured I would send a PR for either you or Chase to pick up on :)
Original Source:
#23
gazpachoking@423499e