Remove sync interface, add asyncio discovery #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rytilahti
commented
Jan 12, 2020
•
rytilahti
commented
- Closes Remove sync interface wrapper #12 and Convert discovery to use asyncio #7
- Converts cli to use asyncio.run() where needed.
- The children from smartstrips is being initialized during the first update call.
* Use asyncio.DatagramProtocol * Cleanup parameters, no more positional arguments Closes python-kasa#7
* This requires python-kasa#13 to be merged. Closes python-kasa#12. * Converts cli to use asyncio.run() where needed. * The children from smartstrips is being initialized during the first update call.
* Simplify tests and use pytest-asyncio. * Removed the emeter tests for child devices, as this information do not seem to exist (based on the dummy sysinfo data). Can be added again if needed. * Remove sync from docstrings.
|
This PR makes the tests pass again (some parts of the strip support was not implemented completely, and some users, e.g., homeassistant simply went and hacked around the internals to make it work), some details in the commit messages 🎉 |
basnijholt
reviewed
Jan 12, 2020
|
Great work! I didn't know about Unfortunately, I don't have the devices to test it (except an HS110). Other than that one comment, LGTM. |
basnijholt
approved these changes
Jan 12, 2020
|
Same applies to me (i.e., only HS110 here, too :-) I'm hoping to pick up some testers soon enough, I'm still porting homeassistant integration at the moment. |
rytilahti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.