Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smartdevice module for led controls #761

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Conversation

rytilahti
Copy link
Member

Allows controlling LED on devices that support it.

image

@rytilahti rytilahti added the enhancement New feature or request label Feb 16, 2024
Base automatically changed from feat/modularize_smartdevice to master February 19, 2024 17:01
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f5175c5) 88.68% compared to head (53117b6) 88.63%.

Files Patch % Lines
kasa/smart/modules/ledmodule.py 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   88.68%   88.63%   -0.06%     
==========================================
  Files          55       56       +1     
  Lines        4129     4152      +23     
  Branches     1070     1073       +3     
==========================================
+ Hits         3662     3680      +18     
- Misses        391      394       +3     
- Partials       76       78       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than test coverage

kasa/smart/modules/ledmodule.py Show resolved Hide resolved
kasa/smart/modules/ledmodule.py Outdated Show resolved Hide resolved
@rytilahti rytilahti merged commit 44b59ef into master Feb 19, 2024
27 of 29 checks passed
@rytilahti rytilahti deleted the feat/smartdevice_led branch February 19, 2024 19:59
@sdb9696 sdb9696 added this to the 0.7.0 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants